Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IP config argument for distpart consistent with the rest of GSF #872

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

thvasilo
Copy link
Contributor

Issue #, if available:

Description of changes:

All other launchers use --ip-config to refer to the IP list file, this PR makes the dist part launcher be consistent with th rest.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@thvasilo thvasilo added 0.3 ready able to trigger the CI labels Jun 11, 2024
@thvasilo thvasilo added this to the 0.3 release milestone Jun 11, 2024
@thvasilo thvasilo self-assigned this Jun 11, 2024
Copy link
Collaborator

@jalencato jalencato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thvasilo thvasilo force-pushed the gsf-fix-dist-part-arg branch from c240ec0 to cac77a8 Compare June 12, 2024 01:25
Copy link
Contributor

@classicsong classicsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thvasilo thvasilo force-pushed the gsf-fix-dist-part-arg branch from 58e12fb to 151c52d Compare June 12, 2024 18:54
@thvasilo
Copy link
Contributor Author

Also added a default value for the dgl-tool-path argument, the path provided is the one we use in the SM and local images. Otherwise the job fails if the argument is not provided.

@thvasilo thvasilo merged commit 9df54d8 into awslabs:main Jun 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.3 ready able to trigger the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants